Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: basic test for peerpods #990

Closed
wants to merge 5 commits into from
Closed

e2e: basic test for peerpods #990

wants to merge 5 commits into from

Conversation

burgerdev
Copy link
Contributor

No description provided.

@burgerdev burgerdev added the no changelog PRs not listed in the release notes label Nov 11, 2024
@burgerdev burgerdev force-pushed the burgerdev/pp-test branch 2 times, most recently from f06eefc to b8abf02 Compare November 11, 2024 15:49
burgerdev
burgerdev commented Nov 13, 2024
View reviewed changes
.github/workflows/e2e_peerpods.yml Outdated
Comment on lines 27 to 28
export azure_resource_group=contrast-ci
export azure_location=germanywestcentral
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these values come from repository vars?

justfile Show resolved Hide resolved
packages/test-peerpods.sh Outdated Show resolved Hide resolved
packages/test-peerpods.sh Outdated Show resolved Hide resolved
@burgerdev burgerdev requested a review from katexochen November 13, 2024 14:44
burgerdev
burgerdev commented Nov 13, 2024
View reviewed changes
packages/test-peerpods.sh Outdated Show resolved Hide resolved
@katexochen katexochen added the do not merge This shouldn't be merged at this point label Nov 13, 2024
burgerdev
burgerdev commented Nov 15, 2024
View reviewed changes
packages/test-peerpods.sh Outdated Show resolved Hide resolved
katexochen
katexochen reviewed Nov 15, 2024
View reviewed changes
.github/workflows/e2e_peerpods.yml Show resolved Hide resolved
packages/test-peerpods.sh Outdated Show resolved Hide resolved
infra/azure-peerpods/main.tf Show resolved Hide resolved
@burgerdev burgerdev requested a review from katexochen November 15, 2024 15:34
@burgerdev burgerdev changed the title wip: basic test for peerpods e2e: basic test for peerpods Nov 15, 2024
@burgerdev burgerdev marked this pull request as ready for review November 15, 2024 15:35
@burgerdev
Copy link
Contributor Author

Rebased in #1005

@burgerdev burgerdev closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen Awaiting requested review from katexochen katexochen is a code owner

Assignees
No one assigned
Labels
do not merge This shouldn't be merged at this point no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burgerdev @katexochen